Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

radar-s3-connector 0.3.2 #122

Merged
merged 1 commit into from
Apr 30, 2024
Merged

radar-s3-connector 0.3.2 #122

merged 1 commit into from
Apr 30, 2024

Conversation

Bdegraaf1234
Copy link
Collaborator

@Bdegraaf1234 Bdegraaf1234 commented Apr 28, 2024

Description of the change

Update the radar-s3-connector pod to the latest appversion

Benefits

Security updates

Possible drawbacks

This image still uses java 11 and should be update again later

Applicable issues

NA

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [<name_of_the_chart>])

@Bdegraaf1234 Bdegraaf1234 requested a review from keyvaann April 28, 2024 12:45
Copy link
Collaborator

@keyvaann keyvaann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we not need to change the image tag in values file as well?

Copy link

Great PR! Please pay attention to the following items before merging:

Files matching charts/*/values.yaml:

  • Is the PR adding a new container? Please reviewer, add it to the models (internal process)
  • Is the PR adding a new parameter? Please, ensure it’s documented in the README.md

This is an automatically generated QA checklist based on modified files.

@Bdegraaf1234
Copy link
Collaborator Author

@keyvaann fixed

Copy link
Collaborator

@keyvaann keyvaann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.
I suggest not using hotfix in version names in future and keeping it numerical

@Bdegraaf1234
Copy link
Collaborator Author

Then we would have a broken release floating around, should/could we then remove that?

@Bdegraaf1234 Bdegraaf1234 merged commit 6eae93e into main Apr 30, 2024
4 checks passed
@keyvaann
Copy link
Collaborator

We can make a new release with a higher number instead of adding -hotfix to it

@Bdegraaf1234 Bdegraaf1234 deleted the radar-s3-connector branch May 1, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants