Skip to content

refactor menu bar into individual classes #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Sep 2, 2025
Merged

refactor menu bar into individual classes #261

merged 22 commits into from
Sep 2, 2025

Conversation

ix0rai
Copy link
Member

@ix0rai ix0rai commented Feb 24, 2025 •
edited
Loading

finally modularises the menu bar. this class was so obnoxious

  • adds consistent state updating (adding list entries, updating button selections, etc) via a unified method
    • some options that weren't previously updated are now updated!
  • adds consistent retranslation via a unified method
    • nearly all submenus were never retranslated, now they are!
  • swaps translations for mapping formats from mapping_format.${service id} to {service id}
    • fixes translations not being properly applied
    • plugins cannot provide their own translations for their formats, this needs to be addressed
  • updates the menu bar to a multiclass/multipackage setup where each submenu is its own class

based on #255

@ix0rai ix0rai added user interface affects the enigma ui refactor improvements that don't impact functionality labels Feb 24, 2025
@ix0rai ix0rai changed the base branch from master to develop/2.7 August 18, 2025 01:09
ix0rai added 6 commits August 30, 2025 17:44
@ix0rai
Merge branch 'develop/2.7' into menu-bar-refactor
c2a5b86 
# Conflicts:
#	enigma-swing/src/main/java/org/quiltmc/enigma/gui/GuiController.java
#	enigma-swing/src/main/java/org/quiltmc/enigma/gui/config/StatsSection.java
#	enigma-swing/src/main/java/org/quiltmc/enigma/gui/dialog/StatsDialog.java
#	enigma-swing/src/main/java/org/quiltmc/enigma/gui/element/MenuBar.java
#	enigma-swing/src/main/java/org/quiltmc/enigma/gui/element/StatsTooltipPanel.java
#	enigma-swing/src/main/java/org/quiltmc/enigma/gui/node/ClassSelectorClassNode.java
#	enigma/src/main/java/org/quiltmc/enigma/api/stats/StatsGenerator.java
@ix0rai
break out stats menu
dc816e1
@ix0rai
checkstyle
7c0cb64
@ix0rai
fully break view menu, add default constructor, properly update state…
8854ec2 
… in StatsMenu
@ix0rai
break out file menu; fix format translations
2a1807d
@ix0rai
checkstyle
046ce5b
supersaiyansubtlety
supersaiyansubtlety requested changes Sep 1, 2025
View reviewed changes
Copy link
Member

@supersaiyansubtlety supersaiyansubtlety left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, way cleaner!

just a few question, nitpicks, and a couple visual bugs

@ix0rai ix0rai merged commit 94025f3 into QuiltMC:develop/2.7 Sep 2, 2025
3 of 4 checks passed
@ix0rai ix0rai deleted the menu-bar-refactor branch September 2, 2025 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@supersaiyansubtlety supersaiyansubtlety supersaiyansubtlety approved these changes

Assignees
No one assigned
Labels
refactor improvements that don't impact functionality user interface affects the enigma ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ix0rai @supersaiyansubtlety