Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added/Fixed default values for TextAnswerView and BooleanAnswerView #93

Merged
merged 29 commits into from
Oct 17, 2023

Conversation

saiful-apx
Copy link
Contributor

@saiful-apx saiful-apx commented Nov 9, 2022

defaultValue attribute was missing/not used from TextAnswerFormat and BooleanAnswerFormat. In this PR they're added.

It contains commits from this PR as well, #92 Please let's clear up #92 so that I can sync them and this one will become more clearer.

@Numoy
Copy link
Member

Numoy commented Nov 14, 2022

Please rebase on main and then we can merge!

@tushkaty
Copy link

Are you guys able to see the result getting updated while navigating back and forth?

@adar2378
Copy link
Contributor

@tushkaty @Numoy Hi I have updated the PR, please check.

@adar2378
Copy link
Contributor

  • used latest build_runner version, which changed .g.dart files
  • there were some android, iOS directory changes made by flutter when I grabbed latest dependencies.
  • updated upstream main with my PR

@Numoy Numoy merged commit cd75004 into QuickBirdEng:main Oct 17, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants