Skip to content

Conversation

@borchero
Copy link
Member

Motivation

This PR fixes two issues in one:

  • Annotating optional collection members currently fails with the following issue:
    TypeError: issubclass() arg 1 must be a class
    
  • Even if that did not fail, inlining optional collection members for sampling would fail due to a missing flag

@borchero borchero self-assigned this Apr 22, 2025
@codecov
Copy link

codecov bot commented Apr 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (54cbc75) to head (c6d4910).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main        #8   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           36        36           
  Lines         1788      1785    -3     
=========================================
- Hits          1788      1785    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@borchero borchero added the fix label Apr 23, 2025
@borchero borchero merged commit 3bf3acf into main Apr 23, 2025
18 checks passed
@borchero borchero deleted the correctly-inline-optionals branch April 23, 2025 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants