add immediate loop dialect with repeat statement #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New Files
Modified Files
|
weinbe58
reviewed
Jan 26, 2026
Comment on lines
+17
to
+21
| def use_repeat(): | ||
| x = 1 | ||
| with immediate_loop.repeat(100): | ||
| x = x + 1 | ||
| return x |
Member
There was a problem hiding this comment.
just a heads up, you don't have any yield/block arguments to the body so this IR would not capture the dataflow dependency of x. I think it would make sense to ban assignment inside the body in this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got the idea to name the dialect "immediate loop" because of the "immediate" instructions you see in MIPS/RISC-V where you need to provide the data to operate on as part of the instruction itself.