Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing example used in test. #469

Merged
merged 5 commits into from
Nov 22, 2022
Merged

Conversation

weinbe58
Copy link
Member

No description provided.

@weinbe58 weinbe58 requested a review from Roger-luo November 14, 2022 16:35
@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2022

Codecov Report

Merging #469 (b73bc81) into master (e32ea5e) will decrease coverage by 16.42%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master     #469       +/-   ##
===========================================
- Coverage   68.16%   51.73%   -16.43%     
===========================================
  Files          73       43       -30     
  Lines        4259     2538     -1721     
===========================================
- Hits         2903     1313     -1590     
+ Misses       1356     1225      -131     
Impacted Files Coverage Δ
lib/BloqadeWaveforms/src/smooth.jl 90.00% <0.00%> (-0.48%) ⬇️
lib/BloqadeWaveforms/src/waveform.jl 94.35% <0.00%> (-0.43%) ⬇️
lib/BloqadeWaveforms/src/interpolate.jl 97.27% <0.00%> (-0.13%) ⬇️
lib/BloqadeSchema/src/schemas/ahs_capabilities.jl
lib/BloqadeGates/src/types.jl
lib/BloqadeGates/src/predefined_pulses.jl
lib/BloqadeExpr/src/interface.jl
lib/BloqadeSchema/src/schemas/ahs_ir.jl
lib/BloqadeSchema/src/validate.jl
lib/BloqadeSchema/src/types.jl
... and 29 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Roger-luo
Copy link
Member

This does not fix the actual bug tho?

@weinbe58
Copy link
Member Author

No response from the issue yet:

SciML/ExponentialUtilities.jl#111

@weinbe58 weinbe58 requested a review from johnzl-777 November 22, 2022 14:24
Copy link
Collaborator

@johnzl-777 johnzl-777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weinbe58 weinbe58 merged commit 390efbe into master Nov 22, 2022
@weinbe58 weinbe58 deleted the weinbe58/krylov_forward_diff_fix branch November 22, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants