-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typos detected by the typos tool #1330
Changes from 11 commits
cfe8561
1054d6a
3d9ee6e
1c0330b
5220701
a5974e1
f23395a
bc38150
47bdb72
c402e8c
b152577
45fccad
48073a6
f4f4a56
6aaff46
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -77,7 +77,7 @@ it just as it would if there was a prebuilt binary available. | |
> [!NOTE] | ||
> To build from source you will need to ensure you have pip >=19.0.0 | ||
installed, which supports PEP-517, or that you have manually installed | ||
`setuptools-rust` prior to running `pip install rustworkx`. If you recieve an | ||
`setuptools-rust` prior to running `pip install rustworkx`. If you receive an | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is an example of high-value contribution because README.md typos are read by everyone and a bit embarrasing |
||
error about `setuptools-rust` not being found you should upgrade pip with | ||
`pip install -U pip` or manually install `setuptools-rust` with | ||
`pip install setuptools-rust` and try again. | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -266,7 +266,7 @@ New Features | |
|
||
- A new method, :meth:`~rustworkx.PyDiGraph.remove_node_retain_edges`, has been | ||
added to the :class:`~rustworkx.PyDiGraph` class. This method can be used to | ||
remove a node and add edges from its predecesors to its successors. | ||
remove a node and add edges from its predecessors to its successors. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I am not even sure if we process this file anymore but it is a high-value find |
||
- Two new methods, :meth:`~rustworkx.PyGraph.edge_list` and | ||
:meth:`~rustworkx.PyGraph.weighted_edge_list`, for getting a list of tuples | ||
with the edge source and target (with or without edge weights) have been | ||
|
@@ -285,7 +285,7 @@ New Features | |
edge list file and will read that file and generate a new object from the | ||
contents. | ||
- Two new methods, :meth:`~rustworkx.PyGraph.extend_from_edge_list` and | ||
:meth:`~rustworkx.PyGraoh.extend_from_weighted_edge_list` has been added | ||
:meth:`~rustworkx.PyGraph.extend_from_weighted_edge_list` has been added | ||
to :class:`~rustworkx.PyGraph` and :class:`~rustworkx.PyDiGraph` | ||
(:meth:`~rustworkx.PyDiGraph.extend_from_edge_list` and | ||
:meth:`~rustworkx.PyDiGraph.extend_from_weighted_edge_list`). This method | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,6 +15,7 @@ | |
"black~=24.8", | ||
"ruff~=0.6", | ||
"setuptools-rust", | ||
"typos~=1.28", | ||
] | ||
|
||
stubs_deps = [ | ||
|
@@ -49,6 +50,8 @@ def lint(session): | |
session.run("ruff", "check", "rustworkx", "retworkx", "setup.py") | ||
session.run("cargo", "fmt", "--all", "--", "--check", external=True) | ||
session.run("python", "tools/find_stray_release_notes.py") | ||
session.run("typos", "--exclude", "releasenotes") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I will keep this is
|
||
session.run("typos", "--no-check-filenames", "releasenotes") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ironically, releasenotes/ is one of the places I'd like to check for typos the most There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
It may be possible to exclude file name checking for all YAML files or even YAML files within |
||
|
||
@nox.session(python=["3"]) | ||
def docs(session): | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
--- | ||
other: | ||
- | | ||
For developement of rustworkx the automated testing environment | ||
For development of rustworkx the automated testing environment | ||
tooling used has switched from Tox to instead | ||
`Nox <https://nox.thea.codes/en/stable/>`__. This is has no impact for | ||
end users and is only relevant if you contribute code to rustworkx. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
fixes: | ||
- | | ||
Fix typos detected by `typos <https://github.com/crate-ci/typos>`_. | ||
Add spell checker invocations to the Nox ``lint`` session. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will revert to use stable, we always want to build on the latest version