Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dominance_frontiers function #1329

Merged
merged 2 commits into from
Nov 23, 2024

Conversation

airwoodix
Copy link
Contributor

As follow-up to #1323, this patch adds the rustworkx.dominance_frontiers function, with the same functionality as networkx.dominance_frontiers.

The algorithm is described in Figure 5 of this paper. The tests are adapted from the networkx ones.

@coveralls
Copy link

coveralls commented Nov 23, 2024

Pull Request Test Coverage Report for Build 11990868092

Details

  • 28 of 28 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 95.869%

Totals Coverage Status
Change from base Build 11989275345: 0.006%
Covered Lines: 18287
Relevant Lines: 19075

💛 - Coveralls

Copy link
Collaborator

@IvanIsCoding IvanIsCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, very nice follow up of #1323

@IvanIsCoding IvanIsCoding added this pull request to the merge queue Nov 23, 2024
Merged via the queue into Qiskit:main with commit 37bee6f Nov 23, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants