Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where edge colors are randomly shuffled in mpl_draw (backport #1312) #1317

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 16, 2024

Closes #1308. A bit embarrasing but we let that slip through in #1204.

The solution is a bit hacky but reusing Python dictionaries was the easiest way to get a set-like object that preservers iteration order.


This is an automatic backport of pull request #1312 done by [Mergify](https://mergify.com).

* Try to make edge_pos iteration deterministic

* Fix minor bug

* Add release note

(cherry picked from commit 44d9fb0)

# Conflicts:
#	rustworkx/visualization/matplotlib.py
Copy link
Contributor Author

mergify bot commented Nov 16, 2024

Cherry-pick of 44d9fb0 has failed:

On branch mergify/bp/stable/0.14/pr-1312
Your branch is up to date with 'origin/stable/0.14'.

You are currently cherry-picking commit 44d9fb0.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   releasenotes/notes/correct-edge-colors-e082e1761e1c060b.yaml

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   rustworkx/visualization/matplotlib.py

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot added the conflicts label Nov 16, 2024
@IvanIsCoding
Copy link
Collaborator

I think we are going to release 0.16. not 0.15.2. If that changes I will reopen

@IvanIsCoding IvanIsCoding deleted the mergify/bp/stable/0.14/pr-1312 branch January 24, 2025 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant