-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Automatically determine coeffs type in SparsePauliOp.from_sparse_list
#15427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
Cryoris
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This approach looks good, thanks for the contribution @RajdeepAher. I left some comments below. Could you also add a test (e.g. based on the reported issue) and a release note documenting the fix?
Pull Request Test Coverage Report for Build 20265992221Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the following people are relevant to this code:
|
Cryoris
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small comment and then I think formatting is not quite right yet -- otherwise LGTM
test/python/quantum_info/operators/symplectic/test_sparse_pauli_op.py
Outdated
Show resolved
Hide resolved
from_sparse_list of SparsePauliOpcoeffs type in SparsePauliOp.from_sparse_list
alexanderivrii
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix. As you have already mentioned somewhere, can you please check if we have the same problem with from_list and provide a similar fix (including tests). You should also add a release note.
Summary
Fixes #15423
Details and comments
Detailed write-up and reasoning here
TODO:
coeffstype inSparsePauliOp.from_sparse_list#15427 (comment)coeffstype inSparsePauliOp.from_sparse_list#15427 (review)