Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

problem-count-formatting #518

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

emily-daitch
Copy link

@emily-daitch emily-daitch commented Mar 26, 2023

Perhaps a little nitpicky, forgive me

I noticed that the problem count number wraps before the difficulty, like this:
image

I thought it might be nice to force them to move together always, like this:
image
I did this by changing the two spans to be a span within a span that is styled with white-space: nowrap

I also noticed with the current &ensp's, wrapping is a little uneven:
image

So I attempted to resolve that too:
image
I did this by moving the spaces from before Medium and before Hard to before Medium and after the Medium count (in it's own span because I think it needs to be there to not break when the quantity is updated(?)
When only hard wraps below, the centering isn't perfect (bc of the space following the medium count), but when all difficulties are forced to their own lines, all three difficulties are centered properly.

Wrapping the count span within the difficulty span allowed me to remove the color styling on the count span(s).

@emily-daitch emily-daitch marked this pull request as ready for review March 26, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant