Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resnet-18 and VGG 11 implementation in E2CNN #46

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

namankhetan
Copy link

@namankhetan namankhetan commented Aug 31, 2021

#45 This the issue for which this pull request is being raised.

@Gabri95
Copy link
Collaborator

Gabri95 commented Sep 2, 2021

Hi @namankhetan

Thanks for creating this pull request!

Unfortunately, I can not merge it yet since it does not pass all the checks (have a look here).
Could you fix the signature in the commits?

Also, before including these examples in the library, I'd like to check the models work well.
Have you already tried to train these models on some dataset? Do you have some results I can try to replicate?

Best,
Gabriele

@namankhetan namankhetan force-pushed the master branch 3 times, most recently from 445f54b to 016958f Compare September 3, 2021 07:31
@namankhetan
Copy link
Author

-Hii @Gabri95 Thanks for appreciating my work in the issue.
I fixed all the checks :),
The models are working fine, I have added test cases at the bottom of the codes. I have also tested the models on ROT-MNIST dataset, they are acheiving accuracy around 98.5-99% ,i haven't done much hyperparameter tuning as it's sufficent to see the correctness of the models.
Also as in the issue #45 @mkool67 mentioned that the models worked for him/her.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants