Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OrchardZSA backward compatability using traits #31
OrchardZSA backward compatability using traits #31
Changes from 1 commit
80dfd60
d3a6f42
86bd33f
989f29b
507a53c
2e31e97
b02478a
e6d1dbe
23a2951
301e7d8
c324006
af29df4
1ea04bb
684c13e
a25a6ad
42f1b0a
2b89fae
8552c97
f35cbe9
f65d5a3
7e50d0b
58f8b3f
738eabe
0fb6dd4
e2c9c30
5322c81
46773e3
3621e0e
a30596b
b3cb453
cf2bd37
da85c71
a5bf5ee
8d27dd7
48f941e
58b7eff
756bb78
6814fc2
64a8ac2
704d3f6
d0d3a6f
35f161d
497c290
d3a9d4e
cf8aca0
b7c7261
d3c7eb0
af5fd9c
5248a0a
8a68152
8dbb582
32842df
3324348
92922be
6c7713f
8922ed6
f75b054
5414d95
396bbde
1ae0a31
adf4d0d
807304d
1bb0b84
923293b
9ecbd65
9337142
8a8aca2
4de57c1
1c694c6
aedcc54
b252579
ce24e86
5474c7c
1cac5b7
ddee3ed
637abbc
9cef0b0
f69907b
9b4c51f
2069bd1
1a21413
de56201
52e6fbb
8d13e7a
36a9319
6cab338
474cfac
ce807ea
8c55c6f
c9d8006
06746f7
36e03e3
5623a78
2c1f636
ac71097
61d223e
b4a70ab
a208dca
fda20b9
cd4d43a
18e3e0d
d6bcf3b
b5d8916
1fbc7de
37e9380
eda965f
6af9ebf
2021f5e
0d2512a
e2c9e93
7f5c0ba
41c7d2e
9c29f27
714fff0
70af809
68d65e0
a8832c9
8a2cbee
03dbe70
a34d146
9df4fb6
493bf53
46db5d4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 23 in halo2_gadgets/src/sinsemilla/chip/hash_to_point.rs
field `0` is never read
Check warning on line 24 in halo2_gadgets/src/sinsemilla/chip/hash_to_point.rs
field `0` is never read
Check warning on line 80 in halo2_gadgets/src/sinsemilla/chip/hash_to_point.rs
very complex type used. Consider factoring parts into `type` definitions
Check warning on line 80 in halo2_gadgets/src/sinsemilla/chip/hash_to_point.rs
very complex type used. Consider factoring parts into `type` definitions
Check warning on line 366 in halo2_gadgets/src/sinsemilla_opt.rs
explicit call to `.into_iter()` in function argument accepting `IntoIterator`
Check warning on line 367 in halo2_gadgets/src/sinsemilla_opt.rs
explicit call to `.into_iter()` in function argument accepting `IntoIterator`
Unchanged files with check annotations Beta
Check warning on line 260 in halo2_gadgets/src/utilities_opt/lookup_range_check.rs
items after a test module
Check warning on line 103 in halo2_gadgets/src/utilities.rs
use of `default` to create a unit struct
Check warning on line 103 in halo2_gadgets/src/utilities.rs
use of `default` to create a unit struct
Check warning on line 118 in halo2_gadgets/src/utilities.rs
use of `default` to create a unit struct
Check warning on line 118 in halo2_gadgets/src/utilities.rs
use of `default` to create a unit struct
Check warning on line 127 in halo2_gadgets/src/utilities.rs
use of `default` to create a unit struct
Check warning on line 127 in halo2_gadgets/src/utilities.rs
use of `default` to create a unit struct
Check warning on line 407 in halo2_gadgets/src/utilities.rs
an array of `Range` that is only one element
Check warning on line 57 in halo2_gadgets/src/sinsemilla_opt/primitives.rs
use of `default` to create a unit struct
Check warning on line 681 in halo2_gadgets/src/sinsemilla.rs
explicit call to `.into_iter()` in function argument accepting `IntoIterator`
Check warning on line 682 in halo2_gadgets/src/sinsemilla.rs
explicit call to `.into_iter()` in function argument accepting `IntoIterator`
Check warning on line 127 in halo2_gadgets/benches/poseidon.rs
the borrowed expression implements the required traits
Check warning on line 159 in halo2_gadgets/src/poseidon.rs
use of `default` to create a unit struct
Check warning on line 159 in halo2_gadgets/src/poseidon.rs
use of `default` to create a unit struct
Check warning on line 206 in halo2_gadgets/src/poseidon.rs
use of `default` to create a unit struct
Check warning on line 206 in halo2_gadgets/src/poseidon.rs
use of `default` to create a unit struct
Check warning on line 220 in halo2_gadgets/src/poseidon/primitives.rs
use of `default` to create a unit struct
Check warning on line 220 in halo2_gadgets/src/poseidon/primitives.rs
use of `default` to create a unit struct
Check warning on line 257 in halo2_gadgets/src/poseidon/primitives.rs
use of `default` to create a unit struct
Check warning on line 257 in halo2_gadgets/src/poseidon/primitives.rs
use of `default` to create a unit struct
Check warning on line 363 in halo2_gadgets/src/poseidon/primitives.rs
use of `default` to create a unit struct
Check warning on line 363 in halo2_gadgets/src/poseidon/primitives.rs
use of `default` to create a unit struct
Check warning on line 88 in halo2_gadgets/src/poseidon/primitives/p128pow5t3.rs
use of `default` to create a unit struct
Check warning on line 72 in halo2_gadgets/src/poseidon/primitives/grain.rs
use of `default` to create a unit struct
Check warning on line 72 in halo2_gadgets/src/poseidon/primitives/grain.rs
use of `default` to create a unit struct
Check warning on line 243 in halo2_gadgets/src/poseidon/pow5.rs
usage of `Iterator::fold` on a type that implements `Try`
Check warning on line 243 in halo2_gadgets/src/poseidon/pow5.rs
usage of `Iterator::fold` on a type that implements `Try`
Check warning on line 254 in halo2_gadgets/src/poseidon/pow5.rs
usage of `Iterator::fold` on a type that implements `Try`
Check warning on line 254 in halo2_gadgets/src/poseidon/pow5.rs
usage of `Iterator::fold` on a type that implements `Try`
Check warning on line 265 in halo2_gadgets/src/poseidon/pow5.rs
usage of `Iterator::fold` on a type that implements `Try`
Check warning on line 265 in halo2_gadgets/src/poseidon/pow5.rs
usage of `Iterator::fold` on a type that implements `Try`
Check warning on line 451 in halo2_gadgets/src/poseidon/pow5.rs
the borrowed expression implements the required traits
Check warning on line 451 in halo2_gadgets/src/poseidon/pow5.rs
the borrowed expression implements the required traits
Check warning on line 477 in halo2_gadgets/src/poseidon/pow5.rs
the borrowed expression implements the required traits
Check warning on line 477 in halo2_gadgets/src/poseidon/pow5.rs
the borrowed expression implements the required traits
Check warning on line 517 in halo2_gadgets/src/poseidon/pow5.rs
the borrowed expression implements the required traits
Check warning on line 517 in halo2_gadgets/src/poseidon/pow5.rs
the borrowed expression implements the required traits
Check warning on line 373 in halo2_gadgets/src/ecc/chip/mul_fixed.rs
the borrowed expression implements the required traits
Check warning on line 373 in halo2_gadgets/src/ecc/chip/mul_fixed.rs
the borrowed expression implements the required traits
Check warning on line 390 in halo2_gadgets/src/ecc/chip/mul_fixed.rs
the borrowed expression implements the required traits
Check warning on line 390 in halo2_gadgets/src/ecc/chip/mul_fixed.rs
the borrowed expression implements the required traits
Check warning on line 395 in halo2_gadgets/src/ecc/chip/mul_fixed.rs
the borrowed expression implements the required traits
Check warning on line 395 in halo2_gadgets/src/ecc/chip/mul_fixed.rs
the borrowed expression implements the required traits
Check warning on line 52 in halo2_gadgets/src/ecc/chip/constants.rs
the borrowed expression implements the required traits
Check warning on line 52 in halo2_gadgets/src/ecc/chip/constants.rs
the borrowed expression implements the required traits
Check warning on line 65 in halo2_gadgets/src/ecc/chip/constants.rs
the borrowed expression implements the required traits
Check warning on line 65 in halo2_gadgets/src/ecc/chip/constants.rs
the borrowed expression implements the required traits
Check warning on line 72 in halo2_gadgets/src/ecc/chip/constants.rs
the borrowed expression implements the required traits
Check warning on line 72 in halo2_gadgets/src/ecc/chip/constants.rs
the borrowed expression implements the required traits
Check warning on line 200 in halo2_gadgets/src/ecc/chip/constants.rs
the borrowed expression implements the required traits
Check warning on line 200 in halo2_gadgets/src/ecc/chip/constants.rs
the borrowed expression implements the required traits
Check warning on line 217 in halo2_gadgets/src/ecc/chip/constants.rs
the borrowed expression implements the required traits
Check warning on line 217 in halo2_gadgets/src/ecc/chip/constants.rs
the borrowed expression implements the required traits
Check warning on line 220 in halo2_gadgets/src/ecc/chip/constants.rs
the borrowed expression implements the required traits
Check warning on line 220 in halo2_gadgets/src/ecc/chip/constants.rs
the borrowed expression implements the required traits
Check warning on line 308 in halo2_gadgets/src/sha256/table16/spread_table.rs
struct `Variable` is never constructed
Check warning on line 1066 in halo2_proofs/src/dev.rs
usage of `Iterator::fold` on a type that implements `Try`
Check warning on line 105 in halo2_proofs/src/dev/cost.rs
unused doc comment
Check warning on line 105 in halo2_proofs/src/dev/cost.rs
unused doc comment
Check warning on line 105 in halo2_proofs/src/dev/cost.rs
Check warning on line 107 in halo2_proofs/src/dev/cost.rs
unused doc comment
Check warning on line 107 in halo2_proofs/src/dev/cost.rs
unused doc comment
Check warning on line 107 in halo2_proofs/src/dev/cost.rs
Check warning on line 109 in halo2_proofs/src/dev/cost.rs
unused doc comment
Check warning on line 109 in halo2_proofs/src/dev/cost.rs
unused doc comment
Check warning on line 109 in halo2_proofs/src/dev/cost.rs
Check warning on line 328 in halo2_proofs/src/dev/cost.rs
use of `default` to create a unit struct
Check warning on line 328 in halo2_proofs/src/dev/cost.rs
use of `default` to create a unit struct
Check warning on line 371 in halo2_proofs/src/dev/cost.rs
use of `default` to create a unit struct
Check warning on line 414 in halo2_proofs/src/dev/cost.rs
use of `default` to create a unit struct
Check warning on line 414 in halo2_proofs/src/dev/cost.rs
use of `default` to create a unit struct
Check warning on line 159 in halo2_proofs/src/poly.rs
explicit call to `.into_iter()` in function argument accepting `IntoIterator`
Check warning on line 159 in halo2_proofs/src/poly.rs
explicit call to `.into_iter()` in function argument accepting `IntoIterator`
Check warning on line 167 in halo2_proofs/src/poly.rs
this bound is already specified as the supertrait of `ExactSizeIterator`
Check warning on line 167 in halo2_proofs/src/poly.rs
this bound is already specified as the supertrait of `ExactSizeIterator`
Check warning on line 174 in halo2_proofs/src/poly.rs
explicit call to `.into_iter()` in function argument accepting `IntoIterator`
Check warning on line 174 in halo2_proofs/src/poly.rs
explicit call to `.into_iter()` in function argument accepting `IntoIterator`
Check warning on line 208 in halo2_proofs/src/poly/multiopen.rs
assigning the result of `Clone::clone()` may be inefficient
Check warning on line 208 in halo2_proofs/src/poly/multiopen.rs
assigning the result of `Clone::clone()` may be inefficient
Check warning on line 105 in halo2_proofs/src/poly/multiopen/prover.rs
explicit call to `.into_iter()` in function argument accepting `IntoIterator`
Check warning on line 105 in halo2_proofs/src/poly/multiopen/prover.rs
explicit call to `.into_iter()` in function argument accepting `IntoIterator`
Check warning on line 78 in halo2_proofs/src/poly/evaluator.rs
use of `default` to create a unit struct
Check warning on line 78 in halo2_proofs/src/poly/evaluator.rs
use of `default` to create a unit struct
Check warning on line 124 in halo2_proofs/src/poly/evaluator.rs
use of `default` to create a unit struct
Check warning on line 124 in halo2_proofs/src/poly/evaluator.rs
use of `default` to create a unit struct
Check warning on line 549 in halo2_proofs/src/poly/domain.rs
the borrowed expression implements the required traits
Check warning on line 559 in halo2_proofs/src/poly/domain.rs
the borrowed expression implements the required traits
Check warning on line 206 in halo2_proofs/src/plonk/verifier.rs
the borrowed expression implements the required traits
Check warning on line 206 in halo2_proofs/src/plonk/verifier.rs
the borrowed expression implements the required traits
Check warning on line 276 in halo2_proofs/src/plonk/verifier.rs
explicit call to `.into_iter()` in function argument accepting `IntoIterator`
Check warning on line 276 in halo2_proofs/src/plonk/verifier.rs
explicit call to `.into_iter()` in function argument accepting `IntoIterator`
Check warning on line 322 in halo2_proofs/src/plonk/verifier.rs
explicit call to `.into_iter()` in function argument accepting `IntoIterator`
Check warning on line 322 in halo2_proofs/src/plonk/verifier.rs
explicit call to `.into_iter()` in function argument accepting `IntoIterator`
Check warning on line 546 in halo2_proofs/src/plonk/prover.rs
explicit call to `.into_iter()` in function argument accepting `IntoIterator`
Check warning on line 546 in halo2_proofs/src/plonk/prover.rs
explicit call to `.into_iter()` in function argument accepting `IntoIterator`
Check warning on line 547 in halo2_proofs/src/plonk/prover.rs
explicit call to `.into_iter()` in function argument accepting `IntoIterator`
Check warning on line 547 in halo2_proofs/src/plonk/prover.rs
explicit call to `.into_iter()` in function argument accepting `IntoIterator`
Check warning on line 581 in halo2_proofs/src/plonk/prover.rs
explicit call to `.into_iter()` in function argument accepting `IntoIterator`
Check warning on line 581 in halo2_proofs/src/plonk/prover.rs
explicit call to `.into_iter()` in function argument accepting `IntoIterator`
Check warning on line 599 in halo2_proofs/src/plonk/prover.rs
the borrowed expression implements the required traits
Check warning on line 599 in halo2_proofs/src/plonk/prover.rs
the borrowed expression implements the required traits
Check warning on line 707 in halo2_proofs/src/plonk/prover.rs
explicit call to `.into_iter()` in function argument accepting `IntoIterator`
Check warning on line 707 in halo2_proofs/src/plonk/prover.rs
explicit call to `.into_iter()` in function argument accepting `IntoIterator`
Check warning on line 769 in halo2_proofs/src/plonk/circuit.rs
struct `PointIndex` is never constructed
Check warning on line 769 in halo2_proofs/src/plonk/circuit.rs
struct `PointIndex` is never constructed
Check warning on line 769 in halo2_proofs/src/plonk/circuit.rs
Check warning on line 893 in halo2_proofs/src/plonk/circuit.rs
explicit call to `.into_iter()` in function argument accepting `IntoIterator`
Check warning on line 893 in halo2_proofs/src/plonk/circuit.rs
explicit call to `.into_iter()` in function argument accepting `IntoIterator`
Check warning on line 1261 in halo2_proofs/src/plonk/circuit.rs
explicit call to `.into_iter()` in function argument accepting `IntoIterator`
Check warning on line 1261 in halo2_proofs/src/plonk/circuit.rs
explicit call to `.into_iter()` in function argument accepting `IntoIterator`
Check warning on line 15 in halo2_proofs/src/multicore.rs
unused imports: `ParallelIterator`, `Scope`
Check warning on line 15 in halo2_proofs/src/multicore.rs
unused imports: `ParallelIterator`, `Scope`
Check warning on line 16 in halo2_proofs/src/multicore.rs
Check warning on line 28 in halo2_proofs/src/multicore.rs
trait `IndexedParallelIterator` is never used
Check warning on line 28 in halo2_proofs/src/multicore.rs
trait `IndexedParallelIterator` is never used
Check warning on line 19 in halo2_proofs/benches/plonk.rs
struct `Variable` is never constructed
Check warning on line 26 in halo2_proofs/tests/plonk_api.rs
struct `Variable` is never constructed
Check warning on line 13 in halo2_proofs/examples/circuit-layout.rs