Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix template selection #1051

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Fix template selection #1051

merged 2 commits into from
Jul 10, 2024

Conversation

senko
Copy link
Contributor

@senko senko commented Jul 9, 2024

Three fixes:

  1. make it clearer to GPT that it should not select a template if the tech is different (and special-casing react here because it seems to always be selected for "plain html/css" projects)
  2. for react+express template, if the user visits http://localhost:3000/ we want to redirect to the vite dev server in development (and only serve frontend built with "npm run build:ui" if we have it, which usually won't be the case in development)
  3. On older versionos of Node, import.meta.dirname is not defined, so use a fallback method to determine the dist folder

@senko senko requested a review from LeonOstrez July 9, 2024 14:40
@LeonOstrez LeonOstrez merged commit 95cfb96 into main Jul 10, 2024
6 checks passed
@LeonOstrez LeonOstrez deleted the fix-template-selection branch July 10, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants