Skip to content

Conversation

@shermanjasonaf
Copy link
Contributor

Summary/Motivation:

The changes to the implementation of the second-stage inequality constraints in PyROS as of #3341 were not accounted for in the implementation of the (scaling factor calculations for the relative) robust feasibility tolerance. In particular, as of #3341, though these inequalities are allowed to have nonzero right-hand sides, the nonzero right-hand sides of the inequalities are not accounted for when calculating the scaling factors. This PR corrects that oversight and adds an accompanying test.

Changes proposed in this PR:

See summary/motivation.

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant