Fix typo in PyROS feasibility tolerance implementation #3817
+34
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary/Motivation:
The changes to the implementation of the second-stage inequality constraints in PyROS as of #3341 were not accounted for in the implementation of the (scaling factor calculations for the relative) robust feasibility tolerance. In particular, as of #3341, though these inequalities are allowed to have nonzero right-hand sides, the nonzero right-hand sides of the inequalities are not accounted for when calculating the scaling factors. This PR corrects that oversight and adds an accompanying test.
Changes proposed in this PR:
See summary/motivation.
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: