Adding iter0_post_solver_creation callback to extensions object #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DLWoodruff
reviewed
Sep 20, 2024
mpisppy/phbase.py
Outdated
| @@ -827,9 +826,12 @@ def Iter0(self): | |||
| stochastic program with the nonanticipativity constraints | |||
| removed. | |||
| """ | |||
|
|
|||
| # JPW: the pre iter0 callback should arguably be called not from within | |||
There was a problem hiding this comment.
There are multiple pathways to iter0, so I would argue that this is the best place. But, in any event, this comment should probably go somewhere else (e.g. an issue)
There was a problem hiding this comment.
Fair - corrected (and opened an issue).
DLWoodruff
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivated by the timed mipgap termination extension, which needs solver plugins to be available in order to install itself.