-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adaptations to Bootstrap 5 / WebPack 5 / Dart Sass #324
base: main
Are you sure you want to change the base?
Conversation
@ldaverio I've just spent a bunch of time upgrading to Webpack 5. Would you mind rebasing? Hugo-bin is used because it means people don't need to have Hugo installed separately and makes it easier for CI. Is it I no longer supported? I upgraded it to the latest version on npm. As for file-loader, can all uses of it be dropped? |
Hello @bertjwregeer, happy New Year! I had done the adaptations on short notice one year ago, because Steve seemed to need them urgently, then he suggested I submit a PR to give them a greater visibility. After that, nothing happened. I'll try to have a look, but I feel I might as well withdraw the pull request, it might just be simpler :) |
I rarely touch frontend stuff these days, and I never could get the darned thing to build, following the instructions in That said, I would still like to see it come to fruition. |
Hi Steve, happy New Year! I'll give it a try, then. These days I do a lot of frontend stuff, especially Next.js (a framework based on React). Gave me lots of satisfaction, lots of hair-pulling too, but finally their last beta seems to solve the problem adequately. My experience of the Node/JS ecosystem is that you can do pretty glitzy things with it, but the software stack is very brittle... PS : Regarding backend / Pyramid, I've recently integrated python_openapi3 after reading one of your e-mails, it's still very rough over the edges, but I rather like it :) |
@ldaverio I will readily admit that I had not seen the original PR get opened, and I was deluged with GitHub notifications, hence the duplication of effort of upgrading to the latest version of web pack. As @stevepiercy we'd still like to see this come to fruition, if you have the time and necessary skillset, I would be ecstatic to review the PR. As it stands you've got a bunch of backend people that are not nearly as good at the frontend stuff! |
This PR offers the following upgrades:
sass
)Several obsolete dependencies have been removed:
bootsrap-sass
(Since version 4, Bootstrap uses Sass instead of Less)hugo-bin
(not required to run Hugo)file-loader
(replaced with asset modules in Webpack 5)TO DO:
bootstrap-multiselect
(used on the Addons page) is not compatible with Bootstrap 5. It should probably be replaced by another component, although a workaround exists.font-awesome
4.6 should probably be replaced by the official package,@fortawesome/fontawesome-free
.