Add exception handling for missing isort package metadata

[maheshsaripalli9]

This commit introduces a try-except block to handle the scenario where the isort package metadata is not available. In such cases, instead of raising an error, the version variable is set to an empty string.

[maheshsaripalli9]

Can you review this code? @timothycrosley

[maheshsaripalli9]

Can you review this PR ? @staticdev

[DanielNoord]

When is this ever the case? If this is the case something else is broken so we shouldn't handle this but fix that bug instead.

[maheshsaripalli9]

If we attempt to execute isort directly from the source code rather than through pip install, the isort package metadata is empty, leading to this error.

[DanielNoord]

Why would you execute it directly from the source code? I'm not sure that is supported?

If you're downloading the source code directly you might as well apply patches yourself?

[maheshsaripalli9]

While uncommon, we currently build our package using our own infrastructure due to licensing constraints and the need to expedite build times.We have a local patch for this problem, but adding a 'try-except' block here would be much better. This is a common way to handle things in Python packages.

…

On Sat, Jan 18, 2025, 3:00 AM Daniël van Noord ***@***.***> wrote: Why would you execute it directly from the source code? I'm not sure that is supported? If you're downloading the source code directly you might as well apply patches yourself? — Reply to this email directly, view it on GitHub <#2226 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AITCZMZWCGVFIMHCVA6KYF32LIX5BAVCNFSM6AAAAABVFWRAWWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOJZGY3TAOBXGA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[DanielNoord]

I guess it is up to @staticdev.

I have never seen this pattern in any of the open source packages I maintain/contribute to.
I also don't really understand the use case, or at least wouldn't consider the use case supported. If you want to download the source files and combine them into a build that is non standard I think you're expected to have do some patching. I wouldn't want to trouble the codebase with that.