Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci-skip] [meta] Update Contributing.md to reflect new naming #337

Closed
wants to merge 4 commits into from
Closed

[ci-skip] [meta] Update Contributing.md to reflect new naming #337

wants to merge 4 commits into from

Conversation

TwoLeggedCat
Copy link
Contributor

Also fixes somewhere where "Paper" should say "Purpur," so please fix that if you close this PR without merging :)

@granny granny self-requested a review May 16, 2021 02:04
@TwoLeggedCat TwoLeggedCat changed the title [meta] Update Contributing.md to reflect new naming [ci-skip] [meta] Update Contributing.md to reflect new naming May 16, 2021
CONTRIBUTING.md Outdated Show resolved Hide resolved
@cittyinthecloud
Copy link

I'd avoid naming patches with brackets if it makes the file names weird, iirc NTFS doesn't like them.

@theomega24
Copy link
Member

it wont affect the file names, git patching omits special characters for the file name

Co-authored-by: BillyGalbreath <[email protected]>
CONTRIBUTING.md Outdated Show resolved Hide resolved
@granny
Copy link
Member

granny commented May 16, 2021

This should be merged once all the patches follow the naming system.

Copy link
Contributor

@Oharass Oharass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@granny
Copy link
Member

granny commented Oct 8, 2021

merged into #351

@granny granny closed this Oct 8, 2021
@TwoLeggedCat TwoLeggedCat deleted the patch-1 branch October 10, 2021 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants