Skip to content

fix: fluids now follow gamerules #1410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Snowiiii merged 2 commits into from
Jan 31, 2026
Merged

fix: fluids now follow gamerules #1410

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a08778
fix: fluids now follow gamerules
RoosterBooster007 Jan 29, 2026
4706fc8
Merge branch 'Pumpkin-MC:master' into fix/fluid-gamerules
RoosterBooster007 Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pumpkin/src/block/fluid/lava.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,9 +167,9 @@ impl FlowingFluid for FlowingLava {
}
}

fn can_convert_to_source(&self, _world: &Arc<World>) -> bool {
// TODO: add game rule check for lava conversion
false
/// Determines if lava can convert to source blocks based on game rules.
fn can_convert_to_source(&self, world: &Arc<World>) -> bool {
world.level_info.load().game_rules.lava_source_conversion
}

async fn spread_to(
Expand Down
6 changes: 3 additions & 3 deletions pumpkin/src/block/fluid/water.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,8 @@ impl FlowingFluid for FlowingWater {
5
}

fn can_convert_to_source(&self, _world: &Arc<World>) -> bool {
// TODO: add game rule check for water conversion
true
/// Determines if water can convert to source blocks based on game rules.
fn can_convert_to_source(&self, world: &Arc<World>) -> bool {
world.level_info.load().game_rules.water_source_conversion
}
}