-
-
Notifications
You must be signed in to change notification settings - Fork 316
Add Items with their corresponding entitys #1153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Joniii11
wants to merge
17
commits into
Pumpkin-MC:master
Choose a base branch
from
Joniii11:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+929
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce it was already existing oops
…StandEntity NBT handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces comprehensive support for armor stands, including their entity logic, item behavior, rotation handling, and equipment slot management. The changes add new modules and types to handle armor stand entities and their rotations (not fully done yet :C). Also added EulerAngle cause it was missing.
Armor Stand Entity & Item Support
ArmorStandEntity
implementation with full support for flags, equipment slots, rotation management, NBT data, and damage handling inarmor_stand.rs
.ArmorStandItem
behavior, allowing players to place armor stands in the world with correct rotation and sound effects inarmor_stand.rs
and registered it in the item registry. [1] [2] [3]Rotation & Math Utilities
rem_euclid
to ensure angles are within [0, 360) degrees inspawn_entity.rs
thanks to @teknostom for helping me with this one.Testing
just get a armor stand in your inventory and place it down.
Please follow our Coding Guidelines