Draft
Conversation
small comment change
graceful shutdown
37670c1 to
dca47ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes (most of the time) if a sidecar dies or is killed the GPU pertaining to that sidecar would hang at 100% and not quit, probably some training thread that gets stuck.
This PR should fix this, when a sidecar dies we detect it and then we kill the client altogether since it doesn't make sense to keep going without one of the GPUs.
How to test
HfAutoand enough batch size32or64should be enough.CUDA_VISIBLE_DEVICES=0,1 DP=2 BATCH_SIZE=1 just dev start-training-localnet-light-clientnvtopin a separate terminal.ps aux | grep psyche.sidecarand kill the process once the node is training.