Open
Conversation
Signed-off-by: pefontana <fontana.pedro93@gmail.com>
Signed-off-by: pefontana <fontana.pedro93@gmail.com>
Signed-off-by: pefontana <fontana.pedro93@gmail.com>
Signed-off-by: pefontana <fontana.pedro93@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplifies the cold start warmup result filtering logic: instead of checking
epoch != 0 && warmup_lr_between.is_none(), uses checkpoint_is_p2p to decide whether to skip results from trainers still warming up. When checkpoint is Hub (first epoch), all trainers are new so nothing gets filtered. When P2P, results from warming-up trainers are skipped.Also adds on-chain validation that cold_start_warmup_steps can actually fit within an epoch, and tightens
CoordinatorConfig::check()to validate epoch_time and warmup_time.