Skip to content

Commit

Permalink
Sets require restart to false for a few core options for emuThree; ad…
Browse files Browse the repository at this point in the history
…ds description for Shader Accurate Mul

I noticed that most options that have 'requiresRestart: true' do not actually apply on restart. These changes should (in theory) fix upscaling not updating, cpu clock not updating, as well as some other core options. On Citra, most settings do not require a restart anyway, except for JIT.

This needs to be tested as I cannot build emuThree for myself.
  • Loading branch information
yippeeeyay authored Jan 12, 2025
1 parent 39b8447 commit 944ab1e
Showing 1 changed file with 10 additions and 10 deletions.
20 changes: 10 additions & 10 deletions Cores/emuThree/PVEmuThreeCore/Core/PVEmuThreeCoreOptions.swift
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ import PVCoreBridge

static var resolutionOption: CoreOption {
.enumeration(.init(title: "Resolution Upscaling",
description: "(Requires Restart)",
requiresRestart: true),
description: nil,
requiresRestart: false),
values: [
.init(title: "1X", description: "1X", value: 1),
.init(title: "2X", description: "2X", value: 2),
Expand All @@ -32,9 +32,9 @@ import PVCoreBridge
}

static var cpuClockOption: CoreOption {
.enumeration(.init(title: "CPU Clock",
description: "(Requires Restart) Underclocking can increase performance but may cause the game to freeze. Overclocking may reduce in game lag but also might cause freezes",
requiresRestart: true),
.enumeration(.init(title: "CPU Clock Speed",
description: "Underclocking can increase performance but may cause the game to freeze. Overclocking may reduce in game lag but also might cause freezes",
requiresRestart: false),
values: [
.init(title: "10%", description: "10%", value: 10),
.init(title: "20%", description: "20%", value: 20),
Expand Down Expand Up @@ -65,15 +65,15 @@ import PVCoreBridge
.bool(.init(
title: "Enable Logging",
description: "May affect performance",
requiresRestart: true),
requiresRestart: false),
defaultValue: false)
}

static var enableNew3DSOption: CoreOption {
.bool(.init(
title: "Enable New 3DS",
description: nil,
requiresRestart: true),
requiresRestart: false),
defaultValue: true)
}

Expand All @@ -91,7 +91,7 @@ import PVCoreBridge
.bool(.init(
title: "Enable Async Shader Compilation",
description: nil,
requiresRestart: true),
requiresRestart: false),
defaultValue: false)
}

Expand Down Expand Up @@ -127,8 +127,8 @@ import PVCoreBridge
static var enableShaderAccurateMulOption: CoreOption {
.bool(.init(
title: "Enable Shader Accurate Mul",
description: nil,
requiresRestart: true),
description: "Some games require this to be enabled to render properly, but slightly reduces performance",
requiresRestart: false),
defaultValue: true)
}

Expand Down

0 comments on commit 944ab1e

Please sign in to comment.