-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Optional skipChecks
to Disable Array Size Check
#154
Add Optional skipChecks
to Disable Array Size Check
#154
Conversation
Can you open the PR for prismarine-nbt? You don't need to wait for a PR to be merged to use it in another PR if there is a chain ; simply set the dependency to point to a branch on github ( |
This option should be added to docs |
PR is open. Let me know if I should approach anything differently.
Good idea! I added this to the docs and type definitions. |
Merging but I note this is missing a test. Would be great to add one to avoid regressions |
/makerelease |
Adds an optional
skipChecks
to disable a max array length check. The array length check was added to address V8 crash concerns, however this is not a concern for some use cases.This implements the support necessary to address #150 and #85. The prismarine-nbt PR that uses these changes can be found here.