Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Optional skipChecks to Disable Array Size Check #154

Merged
merged 12 commits into from
Oct 31, 2024

Conversation

bdkopen
Copy link
Contributor

@bdkopen bdkopen commented Apr 20, 2024

Adds an optional skipChecks to disable a max array length check. The array length check was added to address V8 crash concerns, however this is not a concern for some use cases.

This implements the support necessary to address #150 and #85. The prismarine-nbt PR that uses these changes can be found here.

@bdkopen bdkopen marked this pull request as ready for review April 20, 2024 18:46
@extremeheat
Copy link
Contributor

Can you open the PR for prismarine-nbt? You don't need to wait for a PR to be merged to use it in another PR if there is a chain ; simply set the dependency to point to a branch on github (npm install user/repo#branch will auto update package.json).

@rom1504
Copy link
Member

rom1504 commented Jun 9, 2024

This option should be added to docs

@bdkopen
Copy link
Contributor Author

bdkopen commented Jun 11, 2024

Can you open the PR for prismarine-nbt? You don't need to wait for a PR to be merged to use it in another PR if there is a chain ; simply set the dependency to point to a branch on github (npm install user/repo#branch will auto update package.json).

PR is open. Let me know if I should approach anything differently.

This option should be added to docs

Good idea! I added this to the docs and type definitions.

@rom1504
Copy link
Member

rom1504 commented Oct 31, 2024

Merging but I note this is missing a test. Would be great to add one to avoid regressions

@rom1504 rom1504 merged commit 1173604 into ProtoDef-io:master Oct 31, 2024
1 check passed
@rom1504
Copy link
Member

rom1504 commented Oct 31, 2024

/makerelease

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants