Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protected branch for main? #119

Open
dopplershift opened this issue Aug 27, 2021 · 2 comments
Open

Protected branch for main? #119

dopplershift opened this issue Aug 27, 2021 · 2 comments
Labels
infrastructure Infrastructure related issue

Comments

@dopplershift
Copy link
Contributor

Do we want to make main a protected branch? This means that force-pushing to and deleting the branch is disallowed for everyone (unless we specifically allow it). We also have these options available to us:

  • Require a number of reviews
  • Require a review from a codeowner
  • Require that one or more of the PR status checks pass (by default admins can override as needed)

The last one is one I'm interested in, not as a gate-keeping exercise, but it allows us to use "auto-merge". With that we can mark a PR to merge as soon as all of the required checks pass.

@brian-rose
Copy link
Member

+1 for auto-merging, especially for bot-generated maintenance PRs.

I think we're probably ready to implement the "require a review from a codeowner" rule now that we have a sensible team-based codeowner system in place, so that it's very unlikely we'll be stuck waiting on any one individual who might be away/unavailable to review.

@dcamron
Copy link
Contributor

dcamron commented Jul 7, 2022

EWG today on board with protecting main. Discussions can still be had here about specific PR status/review requirements, but the starting point seemed to be "what's in place in our other repos".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Infrastructure related issue
Projects
Status: Backlog
Development

No branches or pull requests

6 participants