Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contributor's able to merge directly to main #306

Closed
jukent opened this issue Jun 27, 2022 · 3 comments
Closed

Contributor's able to merge directly to main #306

jukent opened this issue Jun 27, 2022 · 3 comments
Labels
infrastructure Infrastructure related issue

Comments

@jukent
Copy link
Contributor

jukent commented Jun 27, 2022

@hCraker pointed out that she is able to commit directly to the main branch. We have protections in place on the portal that require reviewers before merge. Should we recreate that here?
@jukent jukent added the infrastructure Infrastructure related issue label Jun 27, 2022
@dcamron
Copy link
Contributor

dcamron commented Jul 7, 2022

Seconded, I vote we protect main. I'll briefly bring this up at today's EWG if able!

@brian-rose
Copy link
Member

Related (maybe the same?) issue in #119

Consistency in our review and merge policies across different repos would be great!

@dcamron
Copy link
Contributor

dcamron commented Jul 7, 2022

Oh yep! I'll still mention this today, and close this in favor of #119; thanks for the nudges @hCraker @jukent.

@dcamron dcamron closed this as not planned Won't fix, can't repro, duplicate, stale Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
infrastructure Infrastructure related issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@brian-rose @dcamron @jukent