-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RERUM Service Adapter for Online Annotations #84
base: master
Are you sure you want to change the base?
Conversation
* functional TinyThings adapter * functional TinyThings adapter * documentation * Tighten it up * Some notes from playing with this as a TPEN 2.8 viewer/annotator * ready * meh use the functional manifest * meh use the functional manifest * make happy lint * splice() * change delete(). undiff package.json * Let all() have a better chance to only match on the one AnnotationPage it is looking for instead of finding many. * remove null returns. undefined is the natural state. * oops gaurd the get(annoId) * touch of cleanup * also scrub response in helper functions if we are scrubbing them in the main ones * what we think update means * track 'creator' in helper functions as well * ah maybe the attempt to remember this.knownAnnoPage is no good * no this.knownAnnoPage * no this.knownAnnoPage * ughh messy now...co-op will help * ok back to sanity with what we learned * not. fair. id. * all functional now * resolve lint workarounds * Ready for Patrick * suggestions * lint avoidance * cleanup linty loop * fix from note (return []) * codebeat complaints * demo * one last lint thing * touch ups] * functional update() * prepareForRerum * babel accommodation * redundant default * polishing * polishing and happy lint * polishing and happy lint * polishing and happy lint * ready * undiff * ready * cleanup * co-op --------- Co-authored-by: cubap <[email protected]>
The deploy failure is because of upstream issues, not related to the adapter. Should we push in a fix for this first? |
Hi @cubap -- just for more context, there are conflicts between versions of React going on in this repo that are causing that build failure. We hope to update the plugin to work with React 18/Mirador 4 soon. We have been discussing this at Mirador community calls this month and doing exploratory work in branches here and in Mirador core repo. Since these adapters are not dependent on React my opinion is that it's fine to review now. But yes this build step will continue to fail for now. |
I have worked on that. And more ! I have forked mirador-annotations to create mirador-annotations-editor also known at MAE. Take a look : https://github.com/SCENE-CE/mirador-annotation-editor. The biggest challenge was to update to REACT 18. I remove PaperJs to add Konva.js because the project is more active. I also created a wrapper called mirador-annotations-editor-video (MAEV) to support annotation on video. https://github.com/SCENE-CE/mirador-annotation-editor-video To support annotation on video I have a forked mirador called Mirador Video (MV) https://github.com/SCENE-CE/mirador-video And last but not least, we work on a Mirador Multi User environnement (MMU) https://github.com/SCENE-CE/mirador-multi-user. The idea is to have a full application with Mirador workspace, user management, persistance, etc. All are currently in development and we welcomed any help. |
https://mirador.rerum.io/ for our hosted instance |
Adds a RERUM adapter to Mirador for publishing and consuming annotations.