feat: support device plugin daemonset update strategy #628
+12
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please sign your commit to pass the DCO check |
Signed-off-by: devenami <[email protected]>
devenami
force-pushed
the
feat-charts-ds
branch
from
8b56032
to
98d2e34
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Flags with carried forward coverage won't be shown. Click here to find out more. 🚨 Try these New Features:
|
I'm done with it. please review again. |
|
/approve |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
DevicePlugin pod restart will cause business pod restart, this behavior is destructive.
We can provide users with the option to confirm the policy of rolling updates of deviceplugin
Which issue(s) this PR fixes:
Fixes #627
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Users can modify the update policy, and the default is rolling update