Conversation
Summary of ChangesHello @safaricd, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances TabPFN's telemetry by broadening the scope of detected execution environments. It introduces a more structured and comprehensive approach to identifying where the code is being run, moving beyond just interactive kernels to include major cloud providers and notebook platforms. This change provides more granular insights into user environments, which can be valuable for understanding usage patterns and improving the tool's performance and relevance across diverse deployment scenarios. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request refactors the execution environment detection to be more structured and adds support for several new cloud environments like GCP, AWS, Azure, and Databricks. The changes are well-organized, separating kernel detection from environment detection. I've pointed out a potential issue in the environment variable check which might lead to incorrect detection in some edge cases. I've also recommended adding tests for the newly supported environments to ensure their detection logic is correct and robust against future changes.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Change Description
With this change, we keep track of the environment that the user is running TabPFN on. More specifically, previously we were only recording:
Now, we track whether TabPFN is ran on GCP, Azure, AWS or Databricks too.
We do this using a heuristic-based approach - with well-known and automatically set environmental variables.