Skip to content

Track fit_mode and general model init params#54

Merged
safaricd merged 2 commits intomainfrom
track-model-fit-mode
Dec 30, 2025
Merged

Track fit_mode and general model init params#54
safaricd merged 2 commits intomainfrom
track-model-fit-mode

Conversation

@safaricd
Copy link
Collaborator

Change Description

With this change, we start tracking the fit_mode parameter that the estimators are initialized with.

@safaricd safaricd requested a review from oscarkey November 25, 2025 17:36
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @safaricd, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the telemetry system by enabling the tracking of model initialization parameters, including fit_mode, during the model fitting process. This change provides a more comprehensive understanding of how models are configured and used by capturing these critical details and associating them with FitEvent telemetry events.

Highlights

  • New Telemetry Functions: Introduced set_init_params and get_init_params functions to manage the storage and retrieval of model initialization parameters using Python's contextvars.
  • FitEvent Enhancement: The FitEvent telemetry event now includes a new init_params field, which will capture the model's initialization parameters when a fit operation occurs.
  • Parameter Tracking Integration: Modified the event sending mechanism to automatically attach the currently set init_params to FitEvent instances before they are dispatched.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds telemetry for model initialization parameters, specifically for fit_mode. The changes introduce set_init_params and get_init_params to store and retrieve these parameters using context variables, and a new init_params field is added to FitEvent. The implementation is consistent with existing code. My feedback focuses on improving the robustness of the new functions by handling more specific exceptions and adding logging, which will aid in debugging telemetry issues without affecting the main application.

@safaricd safaricd merged commit e772189 into main Dec 30, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants