Track fit_mode and general model init params#54
Conversation
Summary of ChangesHello @safaricd, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the telemetry system by enabling the tracking of model initialization parameters, including Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds telemetry for model initialization parameters, specifically for fit_mode. The changes introduce set_init_params and get_init_params to store and retrieve these parameters using context variables, and a new init_params field is added to FitEvent. The implementation is consistent with existing code. My feedback focuses on improving the robustness of the new functions by handling more specific exceptions and adding logging, which will aid in debugging telemetry issues without affecting the main application.
…track-model-fit-mode
Change Description
With this change, we start tracking the
fit_modeparameter that the estimators are initialized with.