-
Notifications
You must be signed in to change notification settings - Fork 3
Fix issue with invalid state access #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @safaricd, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical issue where the telemetry system would cause the application to crash in environments with restricted file system access. By implementing robust error handling around file path resolution and data persistence operations, the changes ensure that the application can gracefully manage scenarios where it cannot access or write to its configuration files, thus improving stability without completely disabling telemetry. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request addresses an issue where the application would crash if it lacked file-system access to the telemetry state directory. The fix involves wrapping file system operations in try...except blocks to silently handle errors, preventing crashes. The changes are logical and correctly solve the reported problem. I've added a couple of suggestions to use more specific exception handlers instead of the broad except Exception, which will make the code more robust and easier to debug in the future.
brendan-priorlabs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. No access to the homedir is a new one for me!
Change Description
We had an issue in telemetry where an exception was raised whenever the script running TabPFN didn't had file-system read access. This was reported by one user via Discord: