PHP 8.1 compatibility #47
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHP Deprecated: Return type of PrintNode\Entity::jsonSerialize() should either be compatible with JsonSerializable::jsonSerialize(): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in .../vendor/printnode/printnode-php/src/PrintNode/Entity.php on line 105 Explanation: https://stackoverflow.com/a/71133750 PrintNode's class Entity implements \JsonSerializable: https://www.php.net/manual/en/class.jsonserializable.php
|
It doesn't seem like Printnode will ever merge this PR, so I created a new release in the forked repo: https://github.com/Vendic/PrintNode-PHP/releases/tag/2.2.0. |
|
This was done as part of a7616cf. |
|
@tomaszdurda That commit completely breaks the library for PHP7. The mixed return type is only supported in PHP8+ and throws an error in PHP7. The PHP version specified in composer.json needs to be updated to reflect that. This PR included that change but your commit does not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also see #46