Updated the get mask utility for ~10% performance gain on apple silicon#1668
Open
Updated the get mask utility for ~10% performance gain on apple silicon#1668
Conversation
Rohit-Kakodkar
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The mask is created for every single chunk/gll combination but for 99% of chunks the mask is true for all!
Problem
Every masked SIMD kernel call constructed its mask via a per-lane lambda, even for the ~99% of chunks that are full and trivially all-true:
This appeared hot in 13 call sites across field I/O, Jacobians, and boundary conditions.
Fix
Added
get_mask<simd_type>()topoint::indexandpoint::assembly_indexto fast-path the common case:All 13 sites updated. Partial-chunk behavior is unchanged.
Result
Issue Number
If there is an issue created for these changes, link it here
Checklist
Please make sure to check developer documentation on specfem docs.