[DRAFT] SFT distillation with teacher endpoint#1905
Open
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| "orchestrator.use_token_client must be false when orchestrator.rollout_model is configured." | ||
| ) | ||
|
|
||
| return self |
There was a problem hiding this comment.
Missing validation: rollout_model requires SFT loss
Medium Severity
When orchestrator.rollout_model is configured, validate_external_rollout_mode enforces inference=None and use_token_client=False, but does not require trainer.loss.type = "sft". With the default loss, reconstructed rollouts have completion_logprobs = [0.0], so inference_logprobs are all zero. The default loss treats these as the rollout policy logprobs and computes importance ratios from them, producing incorrect gradients and meaningless training.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Note
Medium Risk
Adds a new external-rollout execution path that bypasses local inference/weight broadcast and reconstructs tokens from messages, which can affect rollout-token alignment and training dynamics. The changes touch orchestrator scheduling, sampling args, and loss computation, so misconfiguration or subtle tokenization differences could break training correctness.
Overview
Enables text-only teacher rollout distillation by letting the orchestrator generate rollouts from an external OpenAI-compatible endpoint (
orchestrator.rollout_model) and training the student with an SFT-style masked NLL objective (trainer.loss.type = "sft").The orchestrator now supports an external rollout mode that disables policy weight updates/broadcasting, enforces
inferenceomission anduse_token_client = false, and adjusts scheduler checkpoint/policy-update behavior accordingly. When rollout token IDs/logprobs aren’t returned,interleave_rolloutcan reconstruct per-stepprompt_ids/completion_idsand masks from trajectory messages using the student tokenizer.Adds config validation + tests for the new mode, updates sampling arg construction to only request token/logprob fields when using the token client, introduces the
SFTLossConfig/sft_loss_fnpath in the RL trainer, and documents the new workflow indocs/on_policy_distillation.mdand the TOML config skill guide.Written by Cursor Bugbot for commit ca97c02. This will update automatically on new commits. Configure here.