Open
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Co-authored-by: faresobeid <faresobeid@users.noreply.github.com>
Co-authored-by: faresobeid <faresobeid@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We always have online difficulty filtering but metrics are computed on all rollouts so theyre unchanged.
Basically doesn't ever make sense not to have ODF on, main change this will have is if lots of rollouts have zero advantages, steps will take longer as the batch isn't being filled but this case seems pretty suitable.
This also saves lots of wasted trainer compute which can be used for more efficient training if config is adjusted properly, or can use the idle trainer time for other work
Note
Medium Risk
Changes RL training data selection by filtering out zero-advantage rollouts (except when
skip_verification), which can alter effective batch sizes and training dynamics. Also removes a config option and changes a default (rollouts_per_example), which may impact existing experiment behavior.Overview
Removes
orchestrator.buffer.online_difficulty_filteringand updates configs/tests accordingly; the buffer now always stores all incoming rollouts.Adds advantage-based rollout filtering in the orchestrator: rollouts with ~zero advantage are dropped from training samples by default, while
buffer.skip_verification=truebypasses this to keep distillation runs trainable. Newdifficulty_filter/*metrics are logged andorchestrator.rollouts_per_exampledefault increases from1to4.Written by Cursor Bugbot for commit 93d4f24. This will update automatically on new commits. Configure here.