Add SFT validation eval with val_data#1850
Open
philippnormann wants to merge 5 commits intoPrimeIntellect-ai:mainfrom
Open
Add SFT validation eval with val_data#1850philippnormann wants to merge 5 commits intoPrimeIntellect-ai:mainfrom
philippnormann wants to merge 5 commits intoPrimeIntellect-ai:mainfrom
Conversation
Apply CP compatibility checks to val_data, align eval scheduling with checkpoint step numbering, and document new SFT eval config fields in the changelog.
Add SFTEvalConfig.eval_on_start to support an explicit pre-training validation pass while keeping interval-based eval semantics unchanged by default.
f2ba8af to
fbd6f90
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
val_dataandevalconfig blocks to SFT.val/lossandval/num_batches.evalandval_datato be set together.Why
Train loss alone is not enough for checkpoint selection and overfitting detection.
Before
After
Evidence
sft_fullft_rtext_split_200.tomlValidation
uv run pytest tests/unit/train/sft/test_sft_eval_config.py -qevalwithoutval_data(invalid),val_datawithouteval(invalid), andeval + val_data(valid).val/lossevery 10 steps as configured.Scope
Note
Medium Risk
Touches the core SFT training loop by adding an optional validation pass with distributed reductions; while gated behind new config blocks, it can affect runtime behavior/perf when enabled.
Overview
Adds optional periodic SFT validation driven by new
val_dataandevalconfig blocks (withinterval,num_batches, andeval_on_start) and logsval/loss+val/num_batches.Updates
SFTConfigvalidators to requireevalandval_datatogether and to enforce CP/packing/seq_len/micro-batch constraints for validation data, implements the validation loop insidetrainer/sft/train.py, and adds unit tests covering the new config validation rules.Written by Cursor Bugbot for commit 3c19f26. This will update automatically on new commits. Configure here.