fix: cast Path to str when spawning tail subprocess#1824
Open
enlightened88 wants to merge 1 commit intoPrimeIntellect-ai:mainfrom
Open
fix: cast Path to str when spawning tail subprocess#1824enlightened88 wants to merge 1 commit intoPrimeIntellect-ai:mainfrom
enlightened88 wants to merge 1 commit intoPrimeIntellect-ai:mainfrom
Conversation
Signed-off-by: Андрій Шовкошитний <198119344+enlightened88@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure subprocess receives string path when spawning tail to avoid potential cross-platform Path handling issues
Note
Low Risk
Single-argument type fix when launching a non-critical
tailsubprocess; minimal behavioral impact beyond improved compatibility.Overview
Fixes RL log streaming startup by converting the
Pathfortrainer.stdoutto a plain string when spawningtail -FviaPopen, avoidingPath/subprocess argument handling issues on some platforms.Written by Cursor Bugbot for commit 8e9bd76. This will update automatically on new commits. Configure here.