Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bootstrap compatibility layer page #1862

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

jolelievre
Copy link
Contributor

Questions Answers
Branch? 9.x
Description? Add page explaining the compatibility layer for bootstrap
Fixed ticket? ~

@github-actions github-actions bot added the 9.x label Sep 13, 2024
Copy link
Contributor

@Hlavtox Hlavtox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's a good idea to promote the compatibility layer. If somebody goes through making his module compatible, he should make it properly…

It's not that much work to change few classes here and there and make a proper TPL for Bootstrap 5. Also the javascript is easy to migrate.

@ga-devfront
Copy link
Contributor

I don't think it's a good idea to promote the compatibility layer. If somebody goes through making his module compatible, he should make it properly…

It's not that much work to change few classes here and there and make a proper TPL for Bootstrap 5. Also the javascript is easy to migrate.

I agree but it is also our duty to support and offer a quick solution. Some modules/themes are very large and changing classes/js can take a lot of time, which is time when the module/theme may no longer sell.
I think it is very good to explain the solution while emphasizing that it is still preferable to update the module/theme.

Copy link
Contributor

@matks matks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed with @ga-devfront : we simply document the existence of the library.

I see it as a polyfill. It’s here to help people with complex projects.

If we did not document things that could be used wrong, should we remove the override documentation 😉 ?

@jolelievre jolelievre merged commit c9a042b into PrestaShop:9.x Sep 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants