-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Support direct asset materialization through Python function #19988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Support direct asset materialization through Python function #19988
Conversation
…ws and tasks, in addition to decorator usage.
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
|
…management. Update tests to ensure direct materialization raises appropriate errors outside of execution context.
…e error messaging. Update tests for direct materialization to ensure proper error raising outside of execution contexts.
…arity and maintainability.
…assets across task runs.
|
@Jay-Lokhande are you still working on this PR? We have had some interest in this feature so wanted to follow up to see if this is ready for review or if there is any way we could help! |
|
Hi @robfreedy, thanks for checking in I am still working on this PR the core implementation for direct asset materialization is complete the The failing tests are: all of these tests call materialize() directly within a flow and then check for materialization events but would you be able to help debug this? |
|
hi @Jay-Lokhande! I took a look at the failing tests and think i found the issue which is that i've opened a PR with the fix into your branch: Jay-Lokhande#1 the fix simplifies things a bit:
let me know if that makes sense. feel free to merge it to update your PR here! |
|
@zzstoatzz hi, thank you so much for identifying and fixing the issue |
Checklist
This pull request references any related issue by including "closes
#19634"If this pull request adds new functionality, it includes unit tests that cover the changes
If this pull request removes docs files, it includes redirect settings in
mint.json.If this pull request adds functions or classes, it includes helpful docstrings.
Modified
materialize()function to support both decorator and direct call usageWhen called directly in execution context (flow or task), assets are materialized immediately
Task context is automatically inherited when materializing from within a task
Assets materialized directly become proper upstream dependencies for downstream tasks/assets
closes #19634