Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autohell regression fix #15023

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

miodvallat
Copy link
Contributor

@miodvallat miodvallat commented Jan 9, 2025

Short description

I couldn't help but notice, while configuring recursordist, the shell complaining:

...
checking for the Boost context library... (cached) yes
./configure: line 23134: ]: command not found
checking whether to enable unit test building... yes
...

This was obviously caused by an extra ], the difficult part of figuring where.
It turns out this buglet was introduced in 6a590a16a8d82ea486684ea32318f043e143f176 last september.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@miodvallat miodvallat requested a review from omoerbeek January 9, 2025 10:02
@miodvallat miodvallat marked this pull request as ready for review January 9, 2025 10:02
Copy link
Member

@rgacogne rgacogne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice finding!

@miodvallat
Copy link
Contributor Author

I didn't find anything - the shell did.

@miodvallat miodvallat merged commit acae649 into PowerDNS:master Jan 9, 2025
79 checks passed
@miodvallat miodvallat deleted the autoconf-ate-my-brackets branch January 9, 2025 11:24
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12687640850

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 39 unchanged lines in 10 files lost coverage.
  • Overall coverage increased (+0.02%) to 64.851%

Files with Coverage Reduction New Missed Lines %
pdns/packethandler.cc 1 72.35%
pdns/recursordist/lwres.cc 2 69.66%
pdns/rcpgenerator.cc 2 90.73%
pdns/recursordist/test-syncres_cc2.cc 3 88.91%
pdns/tsigverifier.cc 3 77.22%
pdns/recursordist/recpacketcache.hh 3 89.55%
modules/gpgsqlbackend/spgsql.cc 3 67.7%
pdns/dnsdistdist/dnsdist-carbon.cc 6 62.67%
pdns/recursordist/syncres.cc 6 80.16%
pdns/recursordist/rec-tcp.cc 10 66.07%
Totals Coverage Status
Change from base Build 12679852635: 0.02%
Covered Lines: 126174
Relevant Lines: 163816

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants