Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rec: followup to #14985: init shared pointers as get() might be passed a nullptr #15017

Merged
merged 1 commit into from
Jan 7, 2025
Merged

rec: followup to #14985: init shared pointers as get() might be passed a nullptr #15017

merged 1 commit into from
Jan 7, 2025

Conversation

omoerbeek
Copy link
Member

@omoerbeek omoerbeek commented Jan 7, 2025 •
edited
Loading

Short description

Followup to #14985

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@omoerbeek omoerbeek added the rec label Jan 7, 2025
@omoerbeek omoerbeek added this to the rec-5.3.0 milestone Jan 7, 2025
@omoerbeek omoerbeek requested a review from rgacogne January 7, 2025 10:13
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12649506935

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 45 unchanged lines in 12 files lost coverage.
  • Overall coverage increased (+0.01%) to 64.843%
Files with Coverage Reduction New Missed Lines %
modules/gpgsqlbackend/gpgsqlbackend.cc 1 88.62%
pdns/recursordist/syncres.cc 1 80.29%
pdns/recursordist/lwres.cc 2 69.66%
pdns/signingpipe.cc 2 88.2%
pdns/axfr-retriever.cc 3 67.07%
pdns/iputils.hh 3 78.39%
pdns/iputils.cc 3 54.99%
pdns/opensslsigners.cc 3 61.27%
pdns/dnsdistdist/dnsdist.cc 4 68.85%
pdns/recursordist/rec-tcpout.cc 6 50.79%
Totals Coverage Status
Change from base Build 12634855428: 0.01%
Covered Lines: 126170
Relevant Lines: 163804
💛 - Coveralls

@omoerbeek omoerbeek merged commit a9b1ba5 into PowerDNS:master Jan 7, 2025
79 checks passed
@omoerbeek omoerbeek deleted the rec-shared-ptr-followup branch January 7, 2025 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgacogne rgacogne rgacogne approved these changes

Assignees
No one assigned
Labels
rec
Projects
None yet
Milestone
rec-5.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@omoerbeek @coveralls @rgacogne