fix: misleading logs on unsupported postgresql versions #4525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Postgrest fails on unsupported pg versions. However before killing the thread, it continues to print a few more log messages which were misleading. This commit fixes this by making sure that the no log message should be printed after the unsupported pg version observation and kill the thread immediately. Signed-off-by: Taimoor Zaeem <[email protected]>
wolfgangwalther
approved these changes
Dec 9, 2025
Member
wolfgangwalther
left a comment
wolfgangwalther
left a comment
There was a problem hiding this comment.
Didn't test, but diff LGTM.
Collaborator
Author
|
I forgot to mention that I tested this locally/manually and it works fine 👍. I couldn't figure out an automated way to test this. |
steve-chavez
approved these changes
Dec 9, 2025
Member
steve-chavez
left a comment
steve-chavez
left a comment
There was a problem hiding this comment.
Nice work 👍
I manually tested it by modifying the minimum pg version to 15:
postgrest/src/PostgREST/Config/PgVersion.hs
Lines 27 to 28 in 1724e45
Then on this branch:
$ PGRST_SERVER_TIMING_ENABLED=true postgrest-with-pg-14 -f test/spec/fixtures/load.sql postgrest-run
postgrest-with-pg-14: You can connect with: psql 'postgres:///postgres?host=/tmp/nix-shell-443225-0/postgrest-with-pg-14-uH5/socket' -U postgres
postgrest-with-pg-14: You can tail the logs with: tail -f /tmp/nix-shell-443225-0/postgrest-with-pg-14-uH5/db.log
09/Dec/2025:13:43:45 -0500: Starting PostgREST 15 (pre-release)...
09/Dec/2025:13:43:45 -0500: Admin server listening on 0.0.0.0:3001
09/Dec/2025:13:43:45 -0500: API server listening on 0.0.0.0:3000
09/Dec/2025:13:43:45 -0500: Listening for database notifications on the "pgrst" channel
09/Dec/2025:13:43:45 -0500: Cannot run in this PostgreSQL version (14.18), PostgREST needs at least 15.0
postgrest: thread killed
Master branch shows the same logs as #4519.
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Postgrest fails on unsupported pg versions. However before killing the thread, it continues to print a few more log messages which were misleading. This commit fixes this by making sure that the no log message should be printed after the unsupported pg version observation and kill the thread immediately.
Closes #4519.