fix: regression that truncates error message when offset is out of bounds #4518
+44
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurenceisla
commented
Dec 5, 2025
laurenceisla
commented
Dec 5, 2025
| { matchStatus = 416 | ||
| , matchHeaders = ["Content-Range" <:> "*/0"] | ||
| , matchHeaders = [ "Content-Range" <:> "*/0" | ||
| , "Content-Length" <:> "144"] |
Member
Author
There was a problem hiding this comment.
The test only responds with the Content-Length when it's added to matchHeaders... this is unexpected for a test since it shouldn't modify how our application works. Unless there's a way to make this same request and avoid getting the "Content-Length" or ignore it?
…unds - Happens when offset > the number of rows and when "Prefer: count=exact" header is sent - Regression introduced in commit 57ef998
For when a preference other than return=representation is requested.
laurenceisla
force-pushed
the
fix/truncated-limits-error
branch
from
a99a073 to
ac6451f
Compare
steve-chavez
reviewed
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4455