-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(web-analytics): Add custom bounce rate control #27121
Conversation
Size Change: 0 B Total Size: 1.11 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated16 snapshot changes in total. 0 added, 16 modified, 0 deleted:
Triggered by this commit. |
frontend/src/scenes/settings/environment/BounceRateDuration.tsx
Outdated
Show resolved
Hide resolved
📸 UI snapshots have been updated16 snapshot changes in total. 0 added, 16 modified, 0 deleted:
Triggered by this commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Is this query_modifier
a JSON object for each team? I'm asking because I don't see a DB migration
There's a weird E2E test failing after the `LemonInput` changes, let's revert them to see if this works now
Problem
See https://posthog.slack.com/archives/C05LJK1N3CP/p1734713816519279 for context
Docs PostHog/posthog.com#10206
Changes
Make the bounce rate duration threshold configurable
Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
Added a test - see diff