Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web-analytics): Add custom bounce rate control #27121

Merged
merged 11 commits into from
Dec 26, 2024

Conversation

robbie-c
Copy link
Member

@robbie-c robbie-c commented Dec 21, 2024

Problem

See https://posthog.slack.com/archives/C05LJK1N3CP/p1734713816519279 for context

Docs PostHog/posthog.com#10206

Changes

Make the bounce rate duration threshold configurable

Does this work well for both Cloud and self-hosted?

Yes

How did you test this code?

Added a test - see diff

@robbie-c robbie-c changed the title Add custom bounce rate control feat(web-analytics): Add custom bounce rate control Dec 21, 2024
Copy link
Contributor

github-actions bot commented Dec 21, 2024

Size Change: 0 B

Total Size: 1.11 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.11 MB

compressed-size-action

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

16 snapshot changes in total. 0 added, 16 modified, 0 deleted:

  • chromium: 0 added, 16 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

16 snapshot changes in total. 0 added, 16 modified, 0 deleted:

  • chromium: 0 added, 16 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@robbie-c robbie-c marked this pull request as ready for review December 22, 2024 01:16
Copy link
Member

@rafaeelaudibert rafaeelaudibert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Is this query_modifier a JSON object for each team? I'm asking because I don't see a DB migration

@robbie-c robbie-c enabled auto-merge (squash) December 22, 2024 08:19
There's a weird E2E test failing after the `LemonInput` changes, let's revert them to see if this works now
@robbie-c robbie-c merged commit e56f52b into master Dec 26, 2024
99 checks passed
@robbie-c robbie-c deleted the add-custom-bounce-rate-control branch December 26, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants