feat(experiments): define custom Trends exposure in the modal (#27097)

Co-authored-by: Daniel Bachhuber <[email protected]>
PostHog · Dec 23, 2024 · b22f2f7 · b22f2f7
1 parent 1ec1c14
commit b22f2f7
Show file tree

Hide file tree

Showing 2 changed files with 246 additions and 151 deletions.
diff --git a/cypress/e2e/experiments.cy.ts b/cypress/e2e/experiments.cy.ts
@@ -43,89 +43,4 @@ describe('Experiments', () => {
         // Save experiment
         cy.get('[data-attr="save-experiment"]').first().click()
     })
-
-    const createExperimentInNewUi = (): void => {
-        cy.visit('/experiments')
-
-        // Name, flag key, description
-        cy.get('[data-attr=create-experiment]').first().click()
-        cy.get('[data-attr=experiment-name]').click().type(`${experimentName}`).should('have.value', experimentName)
-        cy.get('[data-attr=experiment-feature-flag-key]')
-            .click()
-            .type(`${featureFlagKey}`)
-            .should('have.value', featureFlagKey)
-        cy.get('[data-attr=experiment-description]')
-            .click()
-            .type('This is the description of the experiment')
-            .should('have.value', 'This is the description of the experiment')
-
-        // Edit variants
-        cy.get('[data-attr="add-test-variant"]').click()
-        cy.get('input[data-attr="experiment-variant-key"][data-key-index="1"]')
-            .clear()
-            .type('test-variant-1')
-            .should('have.value', 'test-variant-1')
-        cy.get('input[data-attr="experiment-variant-key"][data-key-index="2"]')
-            .clear()
-            .type('test-variant-2')
-            .should('have.value', 'test-variant-2')
-
-        // Save experiment
-        cy.get('[data-attr="save-experiment"]').first().click()
-
-        // Set the experiment goal once the experiment is drafted
-        cy.get('[data-attr="add-experiment-goal"]').click()
-
-        // Wait for the goal modal to open and click the confirmation button
-        cy.get('.LemonModal__layout').should('be.visible')
-        cy.contains('Change experiment goal').should('be.visible')
-        cy.get('.LemonModal__content').contains('button', 'Add funnel step').click()
-        cy.get('.LemonModal__footer').contains('button', 'Save').click()
-    }
-
-    it('create, launch and stop experiment with new ui', () => {
-        createExperimentInNewUi()
-        cy.get('[data-attr="experiment-status"]').contains('draft').should('be.visible')
-
-        cy.get('[data-attr="experiment-creation-date"]').contains('a few seconds ago').should('be.visible')
-        cy.get('[data-attr="experiment-start-date"]').should('not.exist')
-
-        cy.wait(1000)
-        cy.get('[data-attr="launch-experiment"]').first().click()
-        cy.get('[data-attr="experiment-creation-date"]').should('not.exist')
-        cy.get('[data-attr="experiment-start-date"]').contains('a few seconds ago').should('be.visible')
-
-        cy.get('[data-attr="stop-experiment"]').first().click()
-        // Wait for the dialog to appear and click the confirmation button
-        cy.get('.LemonModal__layout').should('be.visible')
-        cy.contains('Stop this experiment?').should('be.visible')
-        cy.get('.LemonModal__footer').contains('button', 'Stop').click()
-        // Wait for the dialog to disappear
-        cy.get('[data-attr="experiment-creation-date"]').should('not.exist')
-        cy.get('[data-attr="experiment-start-date"]').contains('a few seconds ago').should('be.visible')
-        cy.get('[data-attr="experiment-end-date"]').contains('a few seconds ago').should('be.visible')
-    })
-
-    it('move start date', () => {
-        createExperimentInNewUi()
-
-        cy.wait(1000)
-        cy.get('[data-attr="launch-experiment"]').first().click()
-
-        cy.get('[data-attr="move-experiment-start-date"]').first().click()
-        cy.get('[data-attr="experiment-start-date-picker"]').should('exist')
-        cy.get('[data-attr="lemon-calendar-month-previous"]').first().click()
-        cy.get('[data-attr="lemon-calendar-day"]').first().click()
-        cy.get('[data-attr="lemon-calendar-select-apply"]').first().click()
-        cy.get('[data-attr="experiment-start-date"]')
-            .contains(/months? ago/)
-            .should('be.visible')
-
-        cy.reload()
-
-        // Check that the start date persists
-        cy.get('[data-attr="experiment-start-date"]')
-            .contains(/months? ago/)
-            .should('be.visible')
-    })
 })