Fix PHP 8.4 deprecation on Client.php constructor (Backwards Compatible) #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@neilkakkar hope you can merge this. Thank you |
|
thanks @ziming , makes sense! I don't have powers to merge anymore, will ping our devEx expert, @mariusandra |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sentry give me tons of warnings on my site running on PHP 8.4 Hope you can merge it. It is backwards compatible.
You were already doing ?HttpClient 1 line above
As a side comment, with your composer targeting minimum PHP 8.0, perhaps you should use some of the newer syntax
Thank you