Skip to content

Commit

Permalink
fix
Browse files Browse the repository at this point in the history
  • Loading branch information
neilkakkar committed Jan 23, 2024
1 parent 5bf38e9 commit 3fa46ff
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion lib/Client.php
Original file line number Diff line number Diff line change
Expand Up @@ -598,7 +598,7 @@ private function addLocalPersonAndGroupProperties(
array $groupProperties
): array {
$allPersonProperties = array_merge(
["\distinct_id" => $distinctId],
["distinct_id" => $distinctId],
$personProperties
);

Expand Down
4 changes: 2 additions & 2 deletions test/FeatureFlagTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -681,15 +681,15 @@ public function testMatchPropertyRelativeDateOperators(): void
"key" => "2022-05-30",
]);
} catch (InconclusiveMatchException $exception) {
self::assertStringContainsString("The date set on the flag is not a valid format", $exception->getMessage());
self::assertStringContainsString("The date provided 1234 must be a string or date object", $exception->getMessage());
}

try {
FeatureFlag::matchProperty($prop_c, [
"key" => 1,
]);
} catch (InconclusiveMatchException $exception) {
self::assertStringContainsString("The date set on the flag is not a valid format", $exception->getMessage());
self::assertStringContainsString("The date provided 1234 must be a string or date object", $exception->getMessage());
}

// # Try all possible relative dates
Expand Down
2 changes: 1 addition & 1 deletion test/PostHogTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -495,7 +495,7 @@ public function testDefaultPropertiesGetAddedProperly(): void
'random_key',
'some_id',
array("company" => "id:5", "instance" => "app.posthog.com"),
array("\distinct_id" => "override"),
array("distinct_id" => "override"),
array("company" => array("\$group_key" => "group_override"), "instance" => array("\$group_key" => "app.posthog.com"))
);
$this->assertEquals(
Expand Down

0 comments on commit 3fa46ff

Please sign in to comment.