fix: checking status is too blunt for paused status #1713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR fixes session recording pause logic by checking a specific _urlBlocked flag instead of the overall recording status, ensuring URL-based blocking works independently from other recording controls like sampling.
- Modified
/src/extensions/replay/sessionrecording.tsto use_urlBlockedflag for pause checks instead of general status - Prevents incorrect pause behavior when sampling has determined recording should be stopped
- Maintains proper buffer flushing when pausing recordings
- Improves precision by separating URL blocking from other recording control mechanisms
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
|
Size Change: +30 B (0%) Total Size: 3.3 MB
ℹ️ View Unchanged
|
rafaeelaudibert
approved these changes
Feb 3, 2025
|
cc @veryayskiy for visibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're checking if status is paused before pausing..
Makes sense, except we have multiple controls and only one status
So, it's possible to be pausable while sampling has determined you shouldn't be recording at all 🤦 . So if
samplinghad determined we should not record this session then we'd init a pause on every rrweb event... which probably causes rrweb events, and down the spiral to madnessLet's check a paused specific flag instead of the top level status