Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

making options parameter optional #709

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

making options parameter optional #709

wants to merge 1 commit into from
+1 −1

Conversation

keshavkrishna
Copy link
Contributor

Title:

  • making options parameter optional in PluginHandler

Related Issues:

narengogi
narengogi suggested changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@narengogi narengogi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked out to this branch, I can still see the same errors after running the tests

@VisargD
Copy link
Collaborator

VisargD commented Nov 8, 2024

Hey @keshavkrishna , were you able to check @narengogi 's comment?

@keshavkrishna
Copy link
Contributor Author

yes I have texted him on discord
Actually the issue he pointed is not in default.tests.ts

narengogi
narengogi approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@narengogi narengogi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narengogi narengogi narengogi approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@keshavkrishna @VisargD @narengogi